Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 7838033: Added login to UITests and added tests to filter. (Closed)

Created:
9 years, 3 months ago by rkc
Modified:
9 years, 3 months ago
Reviewers:
zel, Nirnimesh
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Added login to UITests and added tests to filter. A lot of UITests were failing due to being run without being logged in, added code to login before the test are run. Additionally added the tests that fail on the PFQ and BVT's to the blacklisted tests list. BUG=chromium-os:20022 TEST=Tested the BrowserTests and UITests wrapper on a ChromeOS VM. R=zelidrag@chromium.org,nirnimesh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102285

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review comments + new blacklist files. #

Messages

Total messages: 5 (0 generated)
rkc
9 years, 3 months ago (2011-09-07 18:37:27 UTC) #1
Nirnimesh
LGTM http://codereview.chromium.org/7838033/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right): http://codereview.chromium.org/7838033/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py#newcode7 chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:7: from autotest_lib.client.cros import login unused http://codereview.chromium.org/7838033/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/desktopui_UITest.py File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_UITest/desktopui_UITest.py ...
9 years, 3 months ago (2011-09-07 18:45:23 UTC) #2
zel
http://codereview.chromium.org/7838033/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py File chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py (right): http://codereview.chromium.org/7838033/diff/1/chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py#newcode15 chrome/test/chromeos/autotest/files/client/site_tests/desktopui_BrowserTest/desktopui_BrowserTest.py:15: blacklist = ['FindInPageControllerTest.AcceleratorRestoring', Any chance we can put blacklist ...
9 years, 3 months ago (2011-09-07 19:04:17 UTC) #3
rkc
As discussed, adding blacklists for vm's and blacklists for regular machines; what purpose the tests ...
9 years, 3 months ago (2011-09-22 15:00:08 UTC) #4
zel
9 years, 3 months ago (2011-09-22 15:48:56 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698