WIP: Introduce per-TabContents PrefService.

chrome/browser/profiles/profile.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class gathers state related to a single user profile.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_H_
 #pragma once
 
@@ skipping 17 matching lines @@
 class LibCrosServiceLibraryImpl;
 class ResetDefaultProxyConfigServiceTask;
 }
 
 namespace fileapi {
 class FileSystemContext;
 class SandboxedFileSystemContext;
 }
 
 namespace history {
+class ShortcutsBackend;
 class TopSites;
-class ShortcutsBackend;
 }
 
 namespace net {
+class SSLConfigService;
 class TransportSecurityState;
-class SSLConfigService;
 }
 
 namespace prerender {
 class PrerenderManager;
 }
 
 namespace speech_input {
 class SpeechRecognizer;
 }
 
@@ skipping 20 matching lines @@
 class PrefProxyConfigTracker;
 class PrefService;
 class ProfileSyncFactory;
 class ProfileSyncService;
 class PromoCounter;
 class PromoResourceService;
 class ProtocolHandlerRegistry;
 class SQLitePersistentCookieStore;
 class SSLConfigServiceManager;
 class SpellCheckHost;
+class TabContents;
 class TemplateURLFetcher;
 class TokenService;
 class TransportSecurityPersister;
 class UserScriptMaster;
 class UserStyleSheetWatcher;
 class VisitedLinkEventListener;
 class VisitedLinkMaster;
 class WebDataService;
 class WebUI;
 
@@ skipping 242 matching lines @@
   // Retrieves a pointer to the PrefService that manages the preferences
   // for this user profile.  The PrefService is lazily created the first
   // time that this method is called.
   virtual PrefService* GetPrefs() = 0;
 
   // Retrieves a pointer to the PrefService that manages the preferences
   // for OffTheRecord Profiles.  This PrefService is lazily created the first
   // time that this method is called.
   virtual PrefService* GetOffTheRecordPrefs() = 0;
 
+  // Retrieves a pointer to a special PrefService with overrides per
+  // TabContents. Non-user pref sources such as policy, command-line and
+  // extensions are shared with the profile's main pref service.
+  //
+  // Ideally, this would live in a per-TabContest context object, but since on

[Avi (use Gerrit), 2011/09/07 18:00:56]

What is a "per-TabContent (typo) context object"? You mean a TabContentsWrapper?

Perhaps a tab helper there? I'm not sure I understand the problem.

[Mattias Nissler (ping if slow), 2011/09/07 18:24:46]

Ah, I wasn't aware of TabContentsWrapper :) I'll move this to TabContentsWrapper
then.

Out of curiosity: Why isn't the TabContentsWrapper implementing BrowserContext
then, but Profile? Seems like inverted dependencies to uninitiated me.

+  // the Chrome side there is no per-TabContents context object, it's here in
+  // Profile, which is the content::BrowserContext shared by potentially several
+  // TabContents.
+  virtual PrefService* GetPrefsForTabContents(TabContents* contents) = 0;

[Mattias Nissler (ping if slow), 2011/09/07 17:54:24]

This is the accessor for getting the per-TabContents PrefService. There's no
need to put it here, since the TabContents pointer gives us all we need. In
fact, it may be better to implement this as a static function somewhere?

+
   // Returns the TemplateURLFetcher for this profile. This is owned by the
   // profile.
   virtual TemplateURLFetcher* GetTemplateURLFetcher() = 0;
 
   // Returns the PersonalDataManager associated with this profile.
   virtual PersonalDataManager* GetPersonalDataManager() = 0;
 
   // Returns the request context used for extension-related requests.  This
   // is only used for a separate cookie store currently.
   virtual net::URLRequestContextGetter* GetRequestContextForExtensions() = 0;
@@ skipping 220 matching lines @@
 struct hash<Profile*> {
   std::size_t operator()(Profile* const& p) const {
     return reinterpret_cast<std::size_t>(p);
   }
 };
 
 }  // namespace __gnu_cxx
 #endif
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_H_