Issue 7838019: [ntp4] Include a helper link for importing bookmarks if the user doesn't have any.

Issue 7838019: [ntp4] Include a helper link for importing bookmarks if the user doesn't have any. (Closed)

Created:
9 years, 3 months ago by csilv

Modified:
9 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] Include a helper link for importing bookmarks if the user doesn't have any. BUG=94180 TEST=Fresh install, verify that the bookmarks page has an 'import' link. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99989

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review improvements. #

Total comments: 4

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/bookmarks_page.css	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/bookmarks_page.js	View	1	3 chunks	+27 lines, -0 lines	4 comments	Download
M	chrome/browser/resources/ntp4/new_tab.html	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/7838019/diff/1/chrome/browser/resources/ntp4/bookmarks_page.js File chrome/browser/resources/ntp4/bookmarks_page.js (right): http://codereview.chromium.org/7838019/diff/1/chrome/browser/resources/ntp4/bookmarks_page.js#newcode305 chrome/browser/resources/ntp4/bookmarks_page.js:305: this.querySelector('.tile-page-content').appendChild(importWrapper); don't you need to remove it at some ...

9 years, 3 months ago (2011-09-07 03:55:21 UTC) #2

csilv

Fixed the issue you raised and improved some things, ptal. thx! http://codereview.chromium.org/7838019/diff/1/chrome/browser/resources/ntp4/bookmarks_page.js File chrome/browser/resources/ntp4/bookmarks_page.js (right): ...

9 years, 3 months ago (2011-09-07 06:11:14 UTC) #3

Evan Stade

lgtm http://codereview.chromium.org/7838019/diff/3001/chrome/browser/resources/ntp4/bookmarks_page.js File chrome/browser/resources/ntp4/bookmarks_page.js (right): http://codereview.chromium.org/7838019/diff/3001/chrome/browser/resources/ntp4/bookmarks_page.js#newcode551 chrome/browser/resources/ntp4/bookmarks_page.js:551: * Show the 'Import bookmarks' promo . http://codereview.chromium.org/7838019/diff/3001/chrome/browser/resources/ntp4/bookmarks_page.js#newcode563 ...

9 years, 3 months ago (2011-09-07 19:16:17 UTC) #4

csilv

9 years, 3 months ago (2011-09-07 19:29:59 UTC) #5

http://codereview.chromium.org/7838019/diff/3001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/bookmarks_page.js (right):

http://codereview.chromium.org/7838019/diff/3001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/bookmarks_page.js:551: * Show the 'Import
bookmarks' promo
On 2011/09/07 19:16:18, Evan Stade wrote:
> .

Done.

http://codereview.chromium.org/7838019/diff/3001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/bookmarks_page.js:563: * Hide the 'Import
bookmarks' promo
On 2011/09/07 19:16:18, Evan Stade wrote:
> .

Done.

Expand Messages | Collapse Messages