Issue 7838013: clang/make: Set LINK to $(CXX).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7838013: clang/make: Set LINK to $(CXX). (Closed)

Created:
9 years, 3 months ago by Nico

Modified:
9 years, 3 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

clang/make: Set LINK to $(CXX). Fixes clients that set CXX to a custom clang, such as ASAN. BUG=none TEST=asan bot goes green again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99868

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/7838013/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/7838013/diff/1/build/common.gypi#newcode2019 build/common.gypi:2019: ['LINK', '$(CXX)'], Setting this at all is required to ...

9 years, 3 months ago (2011-09-06 23:37:59 UTC) #1

LGTM

Expand Messages | Collapse Messages