Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2125)

Unified Diff: chrome/browser/content_settings/content_settings_policy_provider.cc

Issue 7837038: Address post commit comments for CL http://codereview.chromium.org/7828022/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/content_settings/host_content_settings_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/content_settings_policy_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_policy_provider.cc b/chrome/browser/content_settings/content_settings_policy_provider.cc
index a47af2bf88bd9a1399489a3cb23ae023a485b77b..45017366755fe9478db50f96b724a3c01d1998dc 100644
--- a/chrome/browser/content_settings/content_settings_policy_provider.cc
+++ b/chrome/browser/content_settings/content_settings_policy_provider.cc
@@ -340,8 +340,8 @@ void PolicyProvider::GetContentSettingsFromPreferences(
secondary_pattern,
content_type,
ResourceIdentifier(NO_RESOURCE_IDENTIFIER),
- static_cast<Value*>(Value::CreateIntegerValue(
- kPrefsForManagedContentSettingsMap[i].setting)));
+ Value::CreateIntegerValue(
+ kPrefsForManagedContentSettingsMap[i].setting));
}
}
}
@@ -388,7 +388,7 @@ void PolicyProvider::GetAutoSelectCertificateSettingsFromPreferences(
scoped_ptr<Value> value(base::JSONReader::Read(pattern_filter_json, true));
if (!value.get()) {
VLOG(1) << "Ignoring invalid certificate auto select setting. Reason:"
- << " Invalid JSON format: " << pattern_filter_json;
+ " Invalid JSON format: " << pattern_filter_json;
continue;
}
@@ -401,7 +401,7 @@ void PolicyProvider::GetAutoSelectCertificateSettingsFromPreferences(
scoped_ptr<Value> cert_filter(cert_filter_ptr);
if (!pattern_read || !filter_read) {
VLOG(1) << "Ignoring invalid certificate auto select setting. Reason:"
- << " Missing pattern or filtern.";
+ " Missing pattern or filter.";
continue;
}
@@ -410,7 +410,7 @@ void PolicyProvider::GetAutoSelectCertificateSettingsFromPreferences(
// Ignore invalid patterns.
if (!pattern.IsValid()) {
VLOG(1) << "Ignoring invalid certificate auto select setting:"
- << " Invalid content settings pattern: " << pattern;
+ " Invalid content settings pattern: " << pattern;
continue;
}
@@ -424,13 +424,11 @@ void PolicyProvider::GetAutoSelectCertificateSettingsFromPreferences(
}
void PolicyProvider::ReadManagedContentSettings(bool overwrite) {
- {
- base::AutoLock auto_lock(lock_);
- if (overwrite)
- value_map_.clear();
- GetContentSettingsFromPreferences(&value_map_);
- GetAutoSelectCertificateSettingsFromPreferences(&value_map_);
- }
+ base::AutoLock auto_lock(lock_);
+ if (overwrite)
+ value_map_.clear();
+ GetContentSettingsFromPreferences(&value_map_);
+ GetAutoSelectCertificateSettingsFromPreferences(&value_map_);
}
// Since the PolicyProvider is a read only content settings provider, all
« no previous file with comments | « no previous file | chrome/browser/content_settings/host_content_settings_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698