Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 7837025: Remove ExitContextStatement. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
fschneider, Steven
CC:
v8-dev
Visibility:
Public.

Description

Remove ExitContextStatement. All the constructs that used it are now properly bracketed in the AST and we handle abrupt exits without try/finally. We can treat normal context exit as occurring implicitly at the end of a body. Committed: http://code.google.com/p/v8/source/detail?r=9189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -60 lines) Patch
M src/ast.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/ast.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +3 lines, -16 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/parser.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M src/rewriter.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
We don't need this anymore.
9 years, 3 months ago (2011-09-07 12:45:03 UTC) #1
Steven
LGTM
9 years, 3 months ago (2011-09-07 13:47:49 UTC) #2
fschneider
9 years, 3 months ago (2011-09-08 08:57:29 UTC) #3
LGTM as well.

Powered by Google App Engine
This is Rietveld 408576698