Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1723)

Issue 7837023: Fix a bug in abrupt exit from with or catch inside finally. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug in abrupt exit from with or catch inside finally. When with or catch is nested inside finally, we were not properly restoring the context in the stack for the finally code. Also, as a small optimization, restore it from the handler block instead of iteratively unwinding contexts. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9160

Patch Set 1 #

Patch Set 2 : Removed platform-specific code from platform-independent files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -19 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/full-codegen.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-95485.js View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 3 months ago (2011-09-07 08:24:38 UTC) #1
fschneider
9 years, 3 months ago (2011-09-07 09:19:54 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698