Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7837018: reconstitute moving 3d out of dev CL. (previous attempt was reverted) (Closed)

Created:
9 years, 3 months ago by nfullagar
Modified:
9 years, 3 months ago
Reviewers:
bradn
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

reconstitute moving 3d out of dev CL. (previous attempt was reverted) previous CL: http://codereview.chromium.org/7737013/ BUG= http://code.google.com/p/chromium/issues/detail?id=94320 TEST= try bots, manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99968

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -1057 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 4 chunks +7 lines, -7 lines 0 comments Download
M gpu/demos/framework/pepper.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
D ppapi/c/dev/pp_graphics_3d_dev.h View 1 1 chunk +0 lines, -48 lines 0 comments Download
M ppapi/c/dev/pp_video_dev.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/dev/ppb_context_3d_dev.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h View 1 1 chunk +1 line, -1 line 0 comments Download
D ppapi/c/dev/ppb_graphics_3d_dev.h View 1 1 chunk +0 lines, -204 lines 0 comments Download
D ppapi/c/dev/ppb_graphics_3d_trusted_dev.h View 1 1 chunk +0 lines, -103 lines 0 comments Download
D ppapi/c/dev/ppb_opengles_dev.h View 1 1 chunk +0 lines, -308 lines 0 comments Download
MM ppapi/c/dev/ppb_surface_3d_dev.h View 1 1 chunk +1 line, -1 line 0 comments Download
D ppapi/c/dev/ppp_graphics_3d_dev.h View 1 1 chunk +0 lines, -18 lines 0 comments Download
A + ppapi/c/pp_graphics_3d.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/c/ppb_graphics_3d.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/c/ppb_opengles.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/c/ppp_graphics_3d.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/c/trusted/ppb_graphics_3d_trusted.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_client_dev.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_client_dev.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_dev.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
D ppapi/cpp/dev/graphics_3d_dev.cc View 1 1 chunk +0 lines, -76 lines 0 comments Download
MM ppapi/cpp/dev/video_decoder_dev.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
MM ppapi/cpp/dev/video_decoder_dev.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + ppapi/cpp/graphics_3d.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/cpp/graphics_3d.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/cpp/graphics_3d_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/cpp/graphics_3d_client.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM ppapi/cpp/instance.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/cpp/instance.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
MM ppapi/examples/gles2/gles2.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
MM ppapi/lib/gl/gles2/gl2ext_ppapi.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/lib/gl/gles2/gl2ext_ppapi.c View 1 4 chunks +4 lines, -4 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/browser_globals.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/plugin_opengles.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.h View 1 3 chunks +8 lines, -10 lines 0 comments Download
MM ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
MM ppapi/native_client/tests/ppapi_browser/ppb_dev/ppapi_ppb_dev.cc View 1 3 chunks +1 line, -5 lines 0 comments Download
MM ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc View 1 8 chunks +97 lines, -13 lines 0 comments Download
MM ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.html View 1 3 chunks +10 lines, -2 lines 0 comments Download
MM ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
MM ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.cc View 1 6 chunks +12 lines, -12 lines 0 comments Download
MM ppapi/ppapi_cpp.gypi View 1 2 3 7 chunks +9 lines, -9 lines 0 comments Download
MM ppapi/proxy/dispatcher.cc View 1 2 chunks +1 line, -1 line 0 comments Download
MM ppapi/proxy/interface_id.h View 1 1 chunk +1 line, -1 line 0 comments Download
MM ppapi/proxy/ppb_context_3d_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
MM ppapi/proxy/ppb_graphics_3d_proxy.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/proxy/ppb_graphics_3d_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
MM ppapi/proxy/ppb_opengles2_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
MM ppapi/proxy/ppb_surface_3d_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
MM ppapi/proxy/ppp_graphics_3d_proxy.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
MM ppapi/proxy/ppp_graphics_3d_proxy.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
MM ppapi/shared_impl/opengles2_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
MM ppapi/shared_impl/opengles2_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
MM ppapi/tests/all_c_includes.h View 1 6 chunks +5 lines, -5 lines 0 comments Download
MM ppapi/tests/all_cpp_includes.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
MM ppapi/tests/test_graphics_3d.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
MM ppapi/tests/test_graphics_3d.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
MM ppapi/thunk/ppb_graphics_3d_api.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
MM ppapi/thunk/ppb_graphics_3d_thunk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
MM ppapi/thunk/ppb_graphics_3d_trusted_thunk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
MM ppapi/thunk/resource_creation_api.h View 1 2 chunks +1 line, -1 line 0 comments Download
MM ppapi/thunk/thunk.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
MM webkit/plugins/ppapi/plugin_module.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
MM webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_opengles_impl.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
MM webkit/plugins/ppapi/ppb_opengles_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
MM webkit/plugins/ppapi/ppb_surface_3d_impl.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nfullagar
9 years, 3 months ago (2011-09-07 00:52:45 UTC) #1
bradn
LGTM, rubberstamp
9 years, 3 months ago (2011-09-07 01:04:39 UTC) #2
nfullagar
9 years, 3 months ago (2011-09-07 17:12:44 UTC) #3 
re-landed at r99968

Powered by Google App Engine
This is Rietveld 408576698