Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 7837014: [Sync] Change strings to reflect sessions -> open tabs naming convention change (Closed)

Created:
9 years, 3 months ago by Nicolas Zea
Modified:
9 years, 3 months ago
Reviewers:
Yaron, tim (not reviewing), tim
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, arv (Not doing code reviews), estade+watch_chromium.org
Visibility:
Public.

Description

[Sync] Change strings to relfect sessions -> open tabs naming convention change BUG=94694 TEST=ensure --enable-sync-tabs,--enable-sync-tabs-for-other-clients switches work. Verify "Open Tabs" on sync setup pane. Verify about:flags describes "Enable syncing open tabs" accurately. Ensure functionality of --enable-sync-tabs-for-other-clients still works. R=tim@chromimum.org,yfriedman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99890

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -29 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/live_sync/live_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Zea
Tim for review, Yaron as FYI since it changes the switches. http://codereview.chromium.org/7837014/diff/2001/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right): ...
9 years, 3 months ago (2011-09-06 23:20:18 UTC) #1
tim (not reviewing)
9 years, 3 months ago (2011-09-06 23:34:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698