Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 7837013: Check in a tool to dump static initializers from a binary (Closed)

Created:
9 years, 3 months ago by Evan Martin
Modified:
9 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Check in a tool to dump static initializers from a binary BUG=94925 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99852

Patch Set 1 #

Patch Set 2 : linux #

Patch Set 3 : cleanup #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
A tools/dump-static-initializers.py View 1 2 1 chunk +107 lines, -0 lines 8 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
9 years, 3 months ago (2011-09-06 22:35:58 UTC) #1
Evan Martin
9 years, 3 months ago (2011-09-06 22:36:08 UTC) #2
Nico
LGTM Since tools/ is getting pretty crowded and tools/mac already exist, maybe put this in ...
9 years, 3 months ago (2011-09-06 22:44:59 UTC) #3
Lei Zhang
9 years, 3 months ago (2011-09-06 23:02:36 UTC) #4
http://codereview.chromium.org/7837013/diff/2002/tools/dump-static-initialize...
File tools/dump-static-initializers.py (right):

http://codereview.chromium.org/7837013/diff/2002/tools/dump-static-initialize...
tools/dump-static-initializers.py:90: (binary,) = sys.argv[1:]
print a help message when len(argv) != 2.

Powered by Google App Engine
This is Rietveld 408576698