Completely disable about:flags

Completely disable about:flags

This is an attempt to improve stability on the m14 branch. I will revert this CL right after merging it to m14.

BUG=95592
TEST=Go to about:flags and chrome://flags. Nothing should be there.
Go to about:version, no --begin-flags and --end-flags should be there.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99883

[Nico, 2011-09-06 19:23:03]

msw: about handler change.
sky: about_flags change.

I'm still compiling this locally and haven't checked if it actually does what I
think it does.

[msw, 2011-09-06 19:48:57]

http://codereview.chromium.org/7837006/diff/2001/chrome/browser/browser_about...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/7837006/diff/2001/chrome/browser/browser_about...
chrome/browser/browser_about_handler.cc:123: // TODO(thakis): Reenable.
This will simply disable the listing of chrome://flags by the builtin provider
and remove it from the list at chrome://chrome-urls, which is good.

However, the DOMUI will still show if a user goes directly to about:flags or
chrome://flags. If you want to disable that, I'd start by looking at
chrome/browser/ui/webui/flags_ui.h/cc.

[sky, 2011-09-06 20:21:02]

I don't think this will catch folks that launch by way of the 'update google
chrome' button. Over time that won't matter, but I suspect canary users
typically launch by way of 'update google chrome'.

[Nico, 2011-09-06 20:39:23]

On 2011/09/06 20:21:02, sky wrote:
> I don't think this will catch folks that launch by way of the 'update google
> chrome' button. Over time that won't matter, but I suspect canary users
> typically launch by way of 'update google chrome'.

That case should be addressed by
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/browse...

msw: Looking at your comment, thanks.

[Nico, 2011-09-06 20:55:37]

msw: doen

[msw, 2011-09-06 21:04:43]

LGTM, but you should check with a WebUI expert for:
chrome/browser/ui/webui/chrome_web_ui_factory.cc

[Nico, 2011-09-06 21:09:48]

+estade for webui owners

[sky, 2011-09-06 21:10:56]

LGTM

[Nico, 2011-09-06 21:32:25]

estade says arv is a better webui OWNER

[arv (Not doing code reviews), 2011-09-06 21:50:34]

LGTM

Maybe add a link to a bug number in the TODOs?

[Nico, 2011-09-06 22:36:21]

Minor tweaks to make tests pass.

Arv: It's my understanding that i'll land this, merge to m14, and then revert
immediately, so I don't think this needs a bug.

[laforge, 2011-09-06 22:39:36]

Created a reference bug.

http://code.google.com/p/chromium/issues/detail?id=95592

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA


On Tue, Sep 6, 2011 at 3:36 PM, <thakis@chromium.org> wrote:

> Minor tweaks to make tests pass.
>
> Arv: It's my understanding that i'll land this, merge to m14, and then
> revert
> immediately, so I don't think this needs a bug.
>
>
>
http://codereview.chromium.**org/7837006/<http://codereview.chromium.org/7837...
>