Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7418)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 7835042: Remove some noisy debug logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addresss Nico's comment. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/client_side_detection_service.cc
diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc
index 2ae761bfa98f87644adc2dea18340075cd0c1a93..684391202a4618fce40babd861890a4e987ade24 100644
--- a/chrome/browser/safe_browsing/client_side_detection_service.cc
+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc
@@ -142,7 +142,7 @@ bool ClientSideDetectionService::IsPrivateIPAddress(
const std::string& ip_address) const {
net::IPAddressNumber ip_number;
if (!net::ParseIPLiteralToNumber(ip_address, &ip_number)) {
- DLOG(WARNING) << "Unable to parse IP address: " << ip_address;
+ VLOG(2) << "Unable to parse IP address: '" << ip_address << "'";
// Err on the side of safety and assume this might be private.
return true;
}
@@ -161,14 +161,14 @@ bool ClientSideDetectionService::IsBadIpAddress(
const std::string& ip_address) const {
net::IPAddressNumber ip_number;
if (!net::ParseIPLiteralToNumber(ip_address, &ip_number)) {
- DLOG(WARNING) << "Unable to parse IP address: " << ip_address;
+ VLOG(2) << "Unable to parse IP address: '" << ip_address << "'";
return false;
}
if (ip_number.size() == net::kIPv4AddressSize) {
ip_number = net::ConvertIPv4NumberToIPv6Number(ip_number);
}
if (ip_number.size() != net::kIPv6AddressSize) {
- DLOG(WARNING) << "Unable to convert IPv4 address to IPv6: " << ip_address;
+ VLOG(2) << "Unable to convert IPv4 address to IPv6: '" << ip_address << "'";
return false; // better safe than sorry.
}
for (BadSubnetMap::const_iterator it = bad_subnets_.begin();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698