Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 7835040: Put test directories of d8-os tests into /tmp/. (Closed)

Created:
9 years, 3 months ago by Yang
Modified:
9 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Put test directories of d8-os tests into /tmp/. Committed: http://code.google.com/p/v8/source/detail?r=9154

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/d8.cc View 1 chunk +1 line, -1 line 1 comment Download
M test/mjsunit/d8-os.js View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL. http://codereview.chromium.org/7835040/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7835040/diff/1/src/d8.cc#newcode686 src/d8.cc:686: #if !defined(V8_SHARED) && !defined(_WIN32) && !defined(_WIN64) There is ...
9 years, 3 months ago (2011-09-06 14:37:51 UTC) #1
rossberg
9 years, 3 months ago (2011-09-06 14:47:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698