Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6630)

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 7835039: Implement the inline extensions/apps install UI for Cocoa. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
===================================================================
--- chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (revision 99418)
+++ chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (working copy)
@@ -49,9 +49,8 @@
const int kRatingFontSizeDelta = -1;
-void AddResourceIcon(int resource_id, views::View* parent) {
- const SkBitmap* skia_image = ResourceBundle::GetSharedInstance().
- GetBitmapNamed(resource_id);
+void AddResourceIcon(const SkBitmap* skia_image, void* data) {
+ views::View* parent = static_cast<views::View*>(data);
views::ImageView* image_view = new views::ImageView();
image_view->SetImage(*skia_image);
parent->AddChildView(image_view);
@@ -195,10 +194,7 @@
rating->SetLayoutManager(new views::BoxLayout(
views::BoxLayout::kHorizontal, 0, 0, 0));
layout->AddView(rating);
- prompt.AppendRatingStars(
- reinterpret_cast<ExtensionInstallUI::Prompt::StarAppender>(
- AddResourceIcon),
- rating);
+ prompt.AppendRatingStars(AddResourceIcon, rating);
views::Label* rating_count = new views::Label(
UTF16ToWide(prompt.GetRatingCount()));
« no previous file with comments | « chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698