chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc - Issue 7835039: Implement the inline extensions/apps install UI for Cocoa.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

Issue 7835039: Implement the inline extensions/apps install UI for Cocoa. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc

===================================================================

--- chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc (revision 99418)

+++ chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc (working copy)

@@ -32,10 +32,8 @@

const double kRatingTextSize = 12.1; // 12.1px = 9pt @ 96dpi

-// Loads an image and adds it as an icon control to the given container.

-GtkWidget* AddResourceIcon(int resource_id, GtkWidget* container) {

- const SkBitmap* icon = ResourceBundle::GetSharedInstance().GetBitmapNamed(

- resource_id);

+// Adds a Skia image as an icon control to the given container.

+GtkWidget* AddResourceIcon(const SkBitmap* icon, GtkWidget* container) {

GdkPixbuf* icon_pixbuf = gfx::GdkPixbufFromSkBitmap(icon);

GtkWidget* icon_widget = gtk_image_new_from_pixbuf(icon_pixbuf);

g_object_unref(icon_pixbuf);