Implement the inline extensions/apps install UI for Cocoa.

chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
@@ skipping 126 matching lines @@
   EXPECT_NE(0u, [[[controller titleField] stringValue] length]);
 
   EXPECT_TRUE([controller subtitleField] != nil);
   EXPECT_NE(0u, [[[controller subtitleField] stringValue] length]);
   EXPECT_NE('^', [[[controller subtitleField] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller warningsField] != nil);
   EXPECT_NSEQ([[controller warningsField] stringValue],
               base::SysUTF16ToNSString(prompt.GetPermission(0)));
 
-  EXPECT_TRUE([controller warningsBox] != nil);
-
   EXPECT_TRUE([controller cancelButton] != nil);
   EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
   EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller okButton] != nil);
   EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
   // Test that cancel calls our delegate.
   [controller cancel:nil];
@@ skipping 70 matching lines @@
 
   // Test control positioning. We don't test exact positioning because we don't
   // want this to depend on string details and localization. But we do know the
   // relative effect that adding a second warning should have on the layout.
   ASSERT_LT([[controller1 window] frame].size.height,
             [[controller2 window] frame].size.height);
 
   ASSERT_LT([[controller1 warningsField] frame].size.height,
             [[controller2 warningsField] frame].size.height);
 
-  ASSERT_LT([[controller1 warningsBox] frame].size.height,
-            [[controller2 warningsBox] frame].size.height);
-
-  ASSERT_EQ([[controller1 warningsBox] frame].origin.y,
-            [[controller2 warningsBox] frame].origin.y);
-
   ASSERT_LT([[controller1 subtitleField] frame].origin.y,
             [[controller2 subtitleField] frame].origin.y);
 
   ASSERT_LT([[controller1 titleField] frame].origin.y,
             [[controller2 titleField] frame].origin.y);
 }
 
 // Test that we can load the skinny prompt correctly, and that the outlets are
 // are hooked up.
 TEST_F(ExtensionInstallDialogControllerTest, BasicsSkinny) {
   scoped_ptr<MockExtensionInstallUIDelegate> delegate(
       new MockExtensionInstallUIDelegate);
 
   // No warnings should trigger skinny prompt.
   ExtensionInstallUI::Prompt no_warnings_prompt(
       ExtensionInstallUI::INSTALL_PROMPT);
 
-  std::vector<string16> warnings;
-
   scoped_nsobject<ExtensionInstallDialogController>
   controller([[ExtensionInstallDialogController alloc]
                initWithParentWindow:test_window()
                             profile:helper_.profile()
                           extension:extension_.get()
                            delegate:delegate.get()
                                icon:&icon_
                              prompt:no_warnings_prompt]);
 
   [controller window];  // force nib load
@@ skipping 13 matching lines @@
   EXPECT_TRUE([controller cancelButton] != nil);
   EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
   EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller okButton] != nil);
   EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller subtitleField] == nil);
   EXPECT_TRUE([controller warningsField] == nil);
-  EXPECT_TRUE([controller warningsBox] == nil);
 }
+
+
+// Test that we can load the inline prompt correctly, and that the outlets are
+// are hooked up.
+TEST_F(ExtensionInstallDialogControllerTest, BasicsInline) {
+  scoped_ptr<MockExtensionInstallUIDelegate> delegate(
+      new MockExtensionInstallUIDelegate);

[Nico, 2011/09/05 22:59:17]

Can't you stack-allocate this?

[Mihai Parparita -not on Chrome, 2011/09/06 00:54:11]

Was just following the pattern in the rest of the file, but yeah, you can.
Switched all the tests.

+
+  // No warnings should trigger skinny prompt.
+  ExtensionInstallUI::Prompt inline_prompt(
+      ExtensionInstallUI::INLINE_INSTALL_PROMPT);
+  inline_prompt.SetInlineInstallWebstoreData("1,000", 3.5, 200);
+
+  scoped_nsobject<ExtensionInstallDialogController>
+  controller([[ExtensionInstallDialogController alloc]
+               initWithParentWindow:test_window()
+                            profile:helper_.profile()
+                          extension:extension_.get()
+                           delegate:delegate.get()
+                               icon:&icon_
+                             prompt:inline_prompt]);
+
+  [controller window];  // force nib load
+
+  // Test the right nib loaded.
+  EXPECT_NSEQ(@"ExtensionInstallPromptInline", [controller windowNibName]);
+
+  // Check all the controls.
+  EXPECT_TRUE([controller iconView] != nil);
+  EXPECT_TRUE([[controller iconView] image] != nil);
+
+  EXPECT_TRUE([controller titleField] != nil);
+  EXPECT_NE(0u, [[[controller titleField] stringValue] length]);
+
+  EXPECT_TRUE([controller cancelButton] != nil);
+  EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
+  EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
+
+  EXPECT_TRUE([controller okButton] != nil);
+  EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
+  EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
+
+  EXPECT_TRUE([controller ratingStars] != nil);
+  EXPECT_EQ(5u, [[[controller ratingStars] subviews] count]);
+
+  EXPECT_TRUE([controller ratingCountField] != nil);
+  EXPECT_NE(0u, [[[controller ratingCountField] stringValue] length]);
+
+  EXPECT_TRUE([controller userCountField] != nil);
+  EXPECT_NE(0u, [[[controller userCountField] stringValue] length]);
+
+  // Though we have no permissions warnings, these should still be hooked up,
+  // just invisible

[Nico, 2011/09/05 22:59:17]

trailing .

[Mihai Parparita -not on Chrome, 2011/09/06 00:54:11]

Done.

+  EXPECT_TRUE([controller subtitleField] != nil);
+  EXPECT_TRUE([[controller subtitleField] isHidden]);
+  EXPECT_TRUE([controller warningsField] != nil);
+  EXPECT_TRUE([[controller warningsField] isHidden]);
+  EXPECT_TRUE([controller warningsSeparator] != nil);
+  EXPECT_TRUE([[controller warningsSeparator] isHidden]);
+}