Reuse linux's config.h to build sdch on android.

Reuse linux's config.h to build sdch on android.


BUG=
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99930

[Peter Beverloo, 2011-09-05 14:39:00]

+wtc for review

Did you run the configure file to generate a config.h file, ensuring that Linux'
config applies to an Android environment as well?

[HaoZheng, 2011-09-05 15:40:19]

On 2011/09/05 14:39:00, Peter Beverloo wrote:
> +wtc for review
> 
> Did you run the configure file to generate a config.h file, ensuring that
Linux'
> config applies to an Android environment as well?

No. We just use it now, and it works fine.

[HaoZheng, 2011-09-06 05:53:51]

I have verified that only '#define HAVE_STRTOQ 1' is invalid on android. But
open-vcdiff would 'Work properly if either strtoll or strtoq is on this system'
gflags.cc:121.

On 2011/09/05 15:40:19, zhenghao wrote:
> On 2011/09/05 14:39:00, Peter Beverloo wrote:
> > +wtc for review
> > 
> > Did you run the configure file to generate a config.h file, ensuring that
> Linux'
> > config applies to an Android environment as well?
> 
> No. We just use it now, and it works fine.

[wtc, 2011-09-06 17:19:47]

LGTM.  I added jar (the sdch owner) as a reviewer.

I highly recommend you run configure to generate a config.h
file and diff it against linux/config.h.  If the differences
can be ignored, then you can use linux/config.h for Android.
Otherwise it is safer to add android/config.h.  Although
Android is based on Linux, its "bionic" libc is different
from the glibc used on Linux.

It seems that you have already run configure and the only
difference is the HAVE_STRTOQ macro.  The reason that
difference can be ignored is not obvious unless you look
at the file open-vcdiff/src/gflags.cc:

// Work properly if either strtoll or strtoq is on this system
#ifdef HAVE_STRTOLL
# define strtoint64  strtoll
# define strtouint64  strtoull
#elif HAVE_STRTOQ
# define strtoint64  strtoq
# define strtouint64  strtouq
#else
// Neither strtoll nor strtoq are defined.  I hope strtol works!
# define strtoint64 strtol
# define strtouint64 strtoul
#endif

Since HAVE_STRTOLL is defined for Android, it doesn't
matter whether HAVE_STRTOQ is defined or not.  I think
we should not rely on this internal property of gflags.cc.

[jar (doing other things), 2011-09-06 17:26:58]

Rubber stamp LGTM.  IF we make a mistake in this, we should get a compile
error... so this seems very safe.  I've copied Lincoln, who provides upstream
support for openvcdiff.  He may have comments.

[HaoZheng, 2011-09-07 01:09:35]

On 2011/09/06 17:26:58, jar wrote:
> Rubber stamp LGTM.  IF we make a mistake in this, we should get a compile
> error... so this seems very safe.  I've copied Lincoln, who provides upstream
> support for openvcdiff.  He may have comments.

Yes. It compiles, so I think it's fine. Actually, I cannot run the configure
script on Android, whose shell is rather limited. I verified all macros
manually.