Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 7835019: Remove unused includes from scanner.h. (Closed)

Created:
9 years, 3 months ago by tfarina
Modified:
9 years, 3 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev, mnaganov (inactive)
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Remove unused includes from scanner.h. This file should also be renamed to something else, as after many refactors, there isn't any Scanner class in there, just four CharacterStream classes. R=lrn@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=9124

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/scanner.h View 1 chunk +0 lines, -2 lines 3 comments Download
M test/cctest/test-regexp.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Lasse, if everything is ok, could you land this to me? PS: Please, keep the ...
9 years, 3 months ago (2011-09-04 20:06:23 UTC) #1
Lasse Reichstein
9 years, 3 months ago (2011-09-05 07:34:15 UTC) #2
LGTM, I'll land it.

http://codereview.chromium.org/7835019/diff/1/src/scanner.h
File src/scanner.h (right):

http://codereview.chromium.org/7835019/diff/1/src/scanner.h#newcode29
src/scanner.h:29: #define V8_SCANNER_H_
We probably should. E.g., scanner => scanner-character-streams and scanner-base
=> scanner.

Powered by Google App Engine
This is Rietveld 408576698