Issue 7835010: Fix thread-checker debug code in GpuChannelHost::MessageFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7835010: Fix thread-checker debug code in GpuChannelHost::MessageFilter. (Closed)

Created:
9 years, 3 months ago by no sievers

Modified:
9 years, 3 months ago

Reviewers:
Ken Russell (switch to Gerrit), commit-bot: I haz the power, nduca, lain Merrick

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix thread-checker debug code in GpuChannelHost::MessageFilter. GpuChannelHost can actually outlive the GPUChannel instance (if there is still a context referencing it). Therefore filter destruction can legally happen on IO, main, or compositor thread. Put more explicit DCHECK()s to for the member function that must be called on the IO thread instead. BUG=95148 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99822

Patch Set 1 #

Patch Set 2 : add include #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -10 lines)			Patch
	M	content/renderer/gpu/gpu_channel_host.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	content/renderer/gpu/gpu_channel_host.cc	View	1	5 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

lain Merrick

Aha, all uses of listeners_ are on the IO thread? Cool, LGTM. Somehow I got ...

9 years, 3 months ago (2011-09-06 12:29:09 UTC) #2

Change committed as 99822

Expand Messages | Collapse Messages