Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 7835006: On Windows, force the output directories to be src/build/{Debug,Release}. (Closed)

Created:
9 years, 3 months ago by tony
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

On Windows, force the output directories to be src/build/{Debug,Release}. This allows develoeprs to build from any sln file and not have to rebuild the world. This is more like how XCode projects are generated. We choose src/build/{Debug,Release} because this is where all.sln generates files and this is what the bots use. This shouldn't require any changes to the bots. BUG=95278 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tony
This works for me, but I'd be curious what you guys think. Before landing, I ...
9 years, 3 months ago (2011-09-02 22:53:04 UTC) #1
bradn
I think that might be good to do, but: 1. You'll want to communicate your ...
9 years, 3 months ago (2011-09-02 22:55:11 UTC) #2
tony
I know of at least one place that depends on the old location: new-run-webkit-tests looks ...
9 years, 3 months ago (2011-09-02 22:58:44 UTC) #3
Dirk Pranke
On Fri, Sep 2, 2011 at 3:58 PM, <tony@chromium.org> wrote: > I know of at ...
9 years, 3 months ago (2011-09-02 23:02:43 UTC) #4
nsylvain
this will also require changes on the bot. Right now we assume that if you ...
9 years, 3 months ago (2011-09-02 23:09:27 UTC) #5
tony
On 2011/09/02 23:09:27, nsylvain wrote: > this will also require changes on the bot. > ...
9 years, 3 months ago (2011-09-02 23:12:13 UTC) #6
tony
9 years, 3 months ago (2011-09-02 23:15:13 UTC) #7
On 2011/09/02 23:12:13, tony wrote:
> On 2011/09/02 23:09:27, nsylvain wrote:
> > this will also require changes on the bot.
> > 
> > Right now we assume that if you load webkit.sln, you'll have the output in
> > src/webkit/release.
> 
> Ah, right.  I will update new-run-webkit-tests first: have it look in
src/build,
> then src/webkit, then src/chrome. After this patch lands I can have it look in
> only src/build.

Oh, and I need to update the bots.  OK, I'll see if I can write a patch for that
too.

Powered by Google App Engine
This is Rietveld 408576698