Moved the following IPCs out of chrome into content where they are handled by

Moved the following IPCs out of chrome into content where they are handled by 
TabContents/RVH which eventually forward the notifications out to the TabContentsDelegate.

1. ViewHostMsg_CrashedPlugin
2. ViewHostMsg_DidStartProvisionalLoadForFrame
3. ViewHostMsg_UpdateTargetURL

The ViewHostMsg_DidStartProvisionalLoadForFrame IPC is still handled by the PrerenderRenderViewHostObserver
object in chrome. Will move that out in a future CL.

BUG=87335
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99775

[jam, 2011-09-03 00:10:47]

http://codereview.chromium.org/7835004/diff/32/chrome/browser/plugin_observer.cc
File chrome/browser/plugin_observer.cc (right):

http://codereview.chromium.org/7835004/diff/32/chrome/browser/plugin_observer...
chrome/browser/plugin_observer.cc:304: void PluginObserver::CrashedPlugin(const
FilePath& plugin_path) {
why is this method still here?

http://codereview.chromium.org/7835004/diff/32/chrome/browser/ui/tab_contents...
File chrome/browser/ui/tab_contents/tab_contents_wrapper.h (right):

http://codereview.chromium.org/7835004/diff/32/chrome/browser/ui/tab_contents...
chrome/browser/ui/tab_contents/tab_contents_wrapper.h:213: PluginObserver*
plugin_observer() {
only tabhelpers have getters, not observers. but it seems like there's no reason
to have that code in pluginobserver anymore since it's not observing that
message

(see line 272 and 325)

http://codereview.chromium.org/7835004/diff/32/content/browser/tab_contents/t...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/7835004/diff/32/content/browser/tab_contents/t...
content/browser/tab_contents/tab_contents.cc:905:
delegate()->DidStartProvisionalLoadForFrame(this, frame_id, is_main_frame,
is this new delegate method really necessary? the prerender tab helper already
implements TabContentsObserver, so can just implement TabContentsObserver to get
it can just watch DidStartProvisionalLoadForFrame notification

[ananta, 2011-09-03 00:43:23]

http://codereview.chromium.org/7835004/diff/32/chrome/browser/plugin_observer.cc
File chrome/browser/plugin_observer.cc (right):

http://codereview.chromium.org/7835004/diff/32/chrome/browser/plugin_observer...
chrome/browser/plugin_observer.cc:304: void PluginObserver::CrashedPlugin(const
FilePath& plugin_path) {
On 2011/09/03 00:10:47, John Abd-El-Malek wrote:
> why is this method still here?
Removed and moved to browser.cc. No reason for it being here. Just lazy :)

http://codereview.chromium.org/7835004/diff/32/chrome/browser/ui/tab_contents...
File chrome/browser/ui/tab_contents/tab_contents_wrapper.h (right):

http://codereview.chromium.org/7835004/diff/32/chrome/browser/ui/tab_contents...
chrome/browser/ui/tab_contents/tab_contents_wrapper.h:213: PluginObserver*
plugin_observer() {
On 2011/09/03 00:10:47, John Abd-El-Malek wrote:
> only tabhelpers have getters, not observers. but it seems like there's no
reason
> to have that code in pluginobserver anymore since it's not observing that
> message
> 
> (see line 272 and 325)

Removed

http://codereview.chromium.org/7835004/diff/32/content/browser/tab_contents/t...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/7835004/diff/32/content/browser/tab_contents/t...
content/browser/tab_contents/tab_contents.cc:905:
delegate()->DidStartProvisionalLoadForFrame(this, frame_id, is_main_frame,
On 2011/09/03 00:10:47, John Abd-El-Malek wrote:
> is this new delegate method really necessary? the prerender tab helper already
> implements TabContentsObserver, so can just implement TabContentsObserver to
get
> it can just watch DidStartProvisionalLoadForFrame notification

Thanks for pointing that out. Done.

[jam, 2011-09-06 17:44:39]

lgtm

http://codereview.chromium.org/7835004/diff/4041/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_tab_helper.h (right):

http://codereview.chromium.org/7835004/diff/4041/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_tab_helper.h:31: 
nit: no need for blank line

[ananta, 2011-09-06 18:42:19]

http://codereview.chromium.org/7835004/diff/4041/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_tab_helper.h (right):

http://codereview.chromium.org/7835004/diff/4041/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_tab_helper.h:31: 
On 2011/09/06 17:44:39, John Abd-El-Malek wrote:
> nit: no need for blank line

Done.