Add lint check against "Foo *bar" and "Foo &bar" declarations.

gcl.py

 #!/usr/bin/env python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 1155 matching lines @@
   print change_info.name + " changelist saved."
   if change_info.MissingTests():
     Warn("WARNING: " + MISSING_TEST_MSG)
 
   # Update the Rietveld issue.
   if change_info.issue and change_info.NeedsUpload():
     change_info.UpdateRietveldDescription()
     change_info.needs_upload = False
     change_info.Save()
   return 0
 

[M-A Ruel, 2011/09/07 19:18:29]

keep 2 lines between file level symbols as per style guide.

[Alexei Svitkine (slow), 2011/09/07 20:27:57]

Done.

-
 @need_change_and_args
 def CMDlint(change_info, args):
   """Runs cpplint.py on all the files in the change list.
 
   Checks all the files in the changelist for possible style violations.
   """
   try:
     import cpplint
+    import cpplint_chromium
   except ImportError:
     ErrorExit("You need to install cpplint.py to lint C++ files.")
   # Change the current working directory before calling lint so that it
   # shows the correct base.
   previous_cwd = os.getcwd()
   os.chdir(change_info.GetLocalRoot())
   # Process cpplints arguments if any.
   filenames = cpplint.ParseArguments(args + change_info.GetFileNames())
 
   white_list = GetCodeReviewSetting("LINT_REGEX")
   if not white_list:
     white_list = DEFAULT_LINT_REGEX
   white_regex = re.compile(white_list)
   black_list = GetCodeReviewSetting("LINT_IGNORE_REGEX")
   if not black_list:
     black_list = DEFAULT_LINT_IGNORE_REGEX
   black_regex = re.compile(black_list)
+  extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
   # Access to a protected member _XX of a client class
   # pylint: disable=W0212
   for filename in filenames:
     if white_regex.match(filename):
       if black_regex.match(filename):
         print "Ignoring file %s" % filename
       else:
-        cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level)
+        cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
+                            extra_check_functions)
     else:
       print "Skipping file %s" % filename
 
   print "Total errors found: %d\n" % cpplint._cpplint_state.error_count
   os.chdir(previous_cwd)
   return 1
 
 
 def DoPresubmitChecks(change_info, committing, may_prompt):
   """Imports presubmit, then calls presubmit.DoPresubmitChecks."""
@@ skipping 239 matching lines @@
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))