Add lint check against "Foo *bar" and "Foo &bar" declarations.

cpplint_chromium.py

+#!/usr/bin/python2.4

[M-A Ruel, 2011/09/07 19:18:29]

Ugh? Why this copyright? Where did you copy that from?

You should just use the standard chromium copyright here if that's new code.

Also, this file is not executable so no shebang.

[Alexei Svitkine (slow), 2011/09/07 19:46:06]

Sorry, should have included the context:

This is a change that was contributed to WebKit's fork of our cpplint.py.

WebKit patch was: http://trac.webkit.org/changeset/46856

Credit Torch Mobile, Inc. who have contributed the WebKit patch in
question.

[M-A Ruel, 2011/09/07 19:52:07]

Ok, but remove the shebang.

[Alexei Svitkine (slow), 2011/09/07 20:27:57]

Done.

+#
+# Copyright (c) 2011 Google Inc. All rights reserved.
+# Copyright (c) 2009 Torch Mobile Inc.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#    * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+#    * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+#    * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import re
+
+# Matches Foo *foo declarations.
+_RE_PATTERN_POINTER_DECLARATION_WHITESPACE = re.compile(
+    r'\s*\w+(?<!\breturn|\bdelete)\s+(?P<pointer_operator>\*|\&)\w+')
+
+def CheckPointerDeclarationWhitespace(filename, clean_lines, linenum, error):
+  """Checks for Foo *foo declarations.
+
+  Args:
+    filename: The name of the current file.
+    clean_lines: A CleansedLines instance containing the file.
+    linenum: The number of the line to check.
+    error: The function to call with any errors found.
+  """
+  line = clean_lines.elided[linenum]
+  matched = _RE_PATTERN_POINTER_DECLARATION_WHITESPACE.match(line)
+  if matched:
+    error(filename, linenum, 'whitespace/declaration', 3,
+          'Declaration has space between type name and %s in %s' %
+          (matched.group('pointer_operator'), matched.group(0).strip()))