Pulling back revision 6635 and 6634 due to broken builds.

Pulling back revision 6635 and 6634 due to broken builds.
TBR
Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6636

[pdox, 2011-09-06 06:38:24]

sanga,

Do you have evidence that the failures were more than flakes?

[Evgeniy Stepanov, 2011-09-06 07:32:30]

On 2011/09/06 06:38:24, pdox wrote:
> sanga,
> 
> Do you have evidence that the failures were more than flakes?

From what I see, my change is a no-op on the failing bots.

[pdox, 2011-09-06 07:42:52]

sanga, 

it is counter-productive to revert commits due to flakes. Jan's change can only
affect the Spec2K bots, which are green. The bots that failed on eugenis' change
went green the next build. Also, none of the failures appear to be related to
the change, but they fit the pattern of common flakes.

In the future, please try to rule out a flake before you revert. In this case,
you could have triggered a rebuild to see if the same bots failed.

[Sang Ahn, 2011-09-06 15:40:44]

It'd be helpful if the committer waited until the build finished, and
notified the sheriff they think the failure is due to flakiness.

On Tue, Sep 6, 2011 at 1:42 AM, <pdox@google.com> wrote:

> sanga,
>
> it is counter-productive to revert commits due to flakes. Jan's change can
> only
> affect the Spec2K bots, which are green. The bots that failed on eugenis'
> change
> went green the next build. Also, none of the failures appear to be related
> to
> the change, but they fit the pattern of common flakes.
>
> In the future, please try to rule out a flake before you revert. In this
> case,
> you could have triggered a rebuild to see if the same bots failed.
>
>
>
>
http://codereview.chromium.**org/7834028/<http://codereview.chromium.org/7834...
>



-- 
Sang Wook Ahn

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.