Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: ppapi/cpp/input_event.h

Issue 7834007: Add comment to PPB_MouseInputEvent version 1.1 that GetMovement hasn't been supported. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/ppb_input_event.h ('k') | ppapi/cpp/input_event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/input_event.h
diff --git a/ppapi/cpp/input_event.h b/ppapi/cpp/input_event.h
index d64e826882839dc606307d5cb571642a42931a56..53dcb045868068aa64e4f61027ebd0eb1e39d459 100644
--- a/ppapi/cpp/input_event.h
+++ b/ppapi/cpp/input_event.h
@@ -123,7 +123,15 @@ class MouseInputEvent : public InputEvent {
/// @param[in] click_count
/// TODO(brettw) figure out exactly what this means.
///
- /// @param[in] mouse_movement The change in position of the mouse.
+ MouseInputEvent(Instance* instance,
+ PP_InputEvent_Type type,
+ PP_TimeTicks time_stamp,
+ uint32_t modifiers,
+ PP_InputEvent_MouseButton mouse_button,
+ const Point& mouse_position,
+ int32_t click_count);
+
+ // @param[in] mouse_movement Currently this parameter is ignored.
MouseInputEvent(Instance* instance,
yzshen1 2011/09/02 23:41:11 The reason why I keep this constructor: Some pdf-r
PP_InputEvent_Type type,
PP_TimeTicks time_stamp,
@@ -140,9 +148,7 @@ class MouseInputEvent : public InputEvent {
/// events, and for all non-mouse events.
PP_InputEvent_MouseButton GetButton() const;
- /// GetPosition() returns the pixel location of a mouse input event. When
- /// the mouse is locked, it returns the last known mouse position just as
- /// mouse lock was entered.
+ /// GetPosition() returns the pixel location of a mouse input event.
///
/// @return The point associated with the mouse event, relative to the upper-
/// left of the instance receiving the event. These values can be negative for
@@ -151,15 +157,6 @@ class MouseInputEvent : public InputEvent {
// TODO(brettw) figure out exactly what this means.
int32_t GetClickCount() const;
-
- /// Returns the change in position of the mouse. When the mouse is locked,
- /// although the mouse position doesn't actually change, this function
- /// still provides movement information, which indicates what the change in
- /// position would be had the mouse not been locked.
- ///
- /// @return The change in position of the mouse, relative to the previous
- /// position.
- Point GetMovement() const;
};
class WheelInputEvent : public InputEvent {
« no previous file with comments | « ppapi/c/ppb_input_event.h ('k') | ppapi/cpp/input_event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698