Add comment to PPB_MouseInputEvent version 1.1 that GetMovement hasn't been supported.

Add comment to PPB_MouseInputEvent version 1.1 that GetMovement hasn't been supported.


BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99792

[yzshen1, 2011-09-02 23:31:07]

Hi, Brett.
Please take a look. Thanks!

[yzshen1, 2011-09-02 23:41:11]

http://codereview.chromium.org/7834007/diff/1/ppapi/cpp/input_event.h
File ppapi/cpp/input_event.h (right):

http://codereview.chromium.org/7834007/diff/1/ppapi/cpp/input_event.h#newcode135
ppapi/cpp/input_event.h:135: MouseInputEvent(Instance* instance,
The reason why I keep this constructor:
Some pdf-related code has been changed to use this new constructor. I don't want
to ask somebody to revert the fix and later ask them to re-apply.

[brettw, 2011-09-06 17:54:20]

I'm wondering if we really need this to go back to dev only to bring it out of
dev in a few weeks. The deltas should be 0 for current builds, right? Do you
think that's OK for now?

[yzshen, 2011-09-06 18:08:36]

On Tue, Sep 6, 2011 at 10:54 AM, <brettw@chromium.org> wrote:

> I'm wondering if we really need this to go back to dev only to bring it out
> of
> dev in a few weeks. The deltas should be 0 for current builds, right? Do
> you
> think that's OK for now?

Yes, the delta will be zero for browser-generated mouse events. (It could be
non-zero if the plugin calls Create().)

If you think that won't be a problem for plugin developers, I am fine with
it. I was thinking that we may receive bug reports from confused developers.

If what your concern about is the extra work, I don't think it would cost
much effort: I could simply revert this CL to bring it out of dev.

Thanks!

>
>
>
http://codereview.chromium.**org/7834007/<http://codereview.chromium.org/7834...
>



-- 
Best regards,
Yuzhu Shen.

[brettw, 2011-09-06 18:09:36]

On Tue, Sep 6, 2011 at 11:08 AM, Yuzhu Shen <yzshen@google.com> wrote:
> On Tue, Sep 6, 2011 at 10:54 AM, <brettw@chromium.org> wrote:
>>
>> I'm wondering if we really need this to go back to dev only to bring it
>> out of
>> dev in a few weeks. The deltas should be 0 for current builds, right? Do
>> you
>> think that's OK for now?
>
> Yes, the delta will be zero for browser-generated mouse events. (It could be
> non-zero if the plugin calls Create().)
> If you think that won't be a problem for plugin developers, I am fine with
> it. I was thinking that we may receive bug reports from confused developers.
>
> If what your concern about is the extra work, I don't think it would cost
> much effort: I could simply revert this CL to bring it out of dev.
> Thanks!

Maybe just document in the C and C++ interfaces that the deltas are currently 0.

Brett

[yzshen1, 2011-09-06 19:52:12]

Hi, Brett.

I have made the change as you suggested.
Please take another look.
Thanks! :)

[brettw, 2011-09-06 19:54:55]

LGTM