Consolidate key, primary key, value cursor messages.

content/renderer/renderer_webidbcursor_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDERER_WEBIDBCURSOR_IMPL_H_
 #define CONTENT_RENDERER_RENDERER_WEBIDBCURSOR_IMPL_H_
 
 #include "base/basictypes.h"
 #include "content/common/indexed_db_key.h"
 #include "content/common/serialized_script_value.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBCallbacks.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBCursor.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBKey.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebSerializedScriptValue.h"
 
 class RendererWebIDBCursorImpl : public WebKit::WebIDBCursor {
  public:
   RendererWebIDBCursorImpl(int32 idb_cursor_id);
   virtual ~RendererWebIDBCursorImpl();
 
   virtual unsigned short direction() const;
-  virtual WebKit::WebIDBKey key() const;
-  virtual WebKit::WebIDBKey primaryKey() const;
-  virtual WebKit::WebSerializedScriptValue value() const;

[michaeln, 2011/09/04 23:08:16]

This is an example of that 'difficult to review' thing mentioned in email.

Why are these methods being removed? The WebCore::IDBCursor class still needs to
retrieve these values in someway. Aren't these methods that way?

[dgrogan, 2011/09/07 01:15:19]

The webkit patch stores key, primary key, and value in the WebCore::IDBCursor
frontend object.  So calls to key(), primaryKey(), and value() don't have to go
over the wire.

   virtual void update(const WebKit::WebSerializedScriptValue& value,
                       WebKit::WebIDBCallbacks* callback,
                       WebKit::WebExceptionCode& ec);
   virtual void continueFunction(const WebKit::WebIDBKey& key,
                                 WebKit::WebIDBCallbacks* callback,
                                 WebKit::WebExceptionCode& ec);
   virtual void deleteFunction(WebKit::WebIDBCallbacks* callback,
                               WebKit::WebExceptionCode& ec);
 
  private:
   int32 idb_cursor_id_;
 };
 
 #endif  // CONTENT_RENDERER_RENDERER_WEBIDBCURSOR_IMPL_H_