Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 7833046: Changing confidence calculation to avoid div by zero (Closed)

Created:
9 years, 3 months ago by dominich
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Confidence ranges were coming in too high and had occasional divide-by-zero leading to CHECK failures. Changed the math and the unit tests to satisfy stricter confidence requirements and remove divide by zero. BUG=95453 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99879

Patch Set 1 #

Patch Set 2 : Tweaking math and unit test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chrome/browser/autocomplete/network_action_predictor.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/network_action_predictor_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dominich
CHECK was too strict. Clamping instead. This is a fix for one of the top ...
9 years, 3 months ago (2011-09-06 15:38:14 UTC) #1
dominich
Clamping was my gut reaction (patch 1) but then I looked into it further and ...
9 years, 3 months ago (2011-09-06 19:27:43 UTC) #2
sky
LGTM
9 years, 3 months ago (2011-09-06 20:06:32 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-06 23:58:29 UTC) #4
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac, revision is 99830, job name
was 7833046-2001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

Powered by Google App Engine
This is Rietveld 408576698