Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: net/base/cookie_store_test_helpers.cc

Issue 7833042: Finalize a CL originally by departed intern ycxiao@ that detaches the loading of cookies from the... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/cookie_store_test_helpers.h ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/cookie_store_test_helpers.cc
===================================================================
--- net/base/cookie_store_test_helpers.cc (revision 99705)
+++ net/base/cookie_store_test_helpers.cc (working copy)
@@ -20,10 +20,10 @@
}
void DelayedCookieMonster::GetCookiesInternalCallback(
- std::string* cookie_line,
- std::vector<CookieStore::CookieInfo>* cookie_info) {
- cookie_line_ = *cookie_line;
- cookie_info_ = *cookie_info;
+ const std::string& cookie_line,
+ const std::vector<CookieStore::CookieInfo>& cookie_info) {
+ cookie_line_ = cookie_line;
+ cookie_info_ = cookie_info;
did_run_ = true;
}
@@ -91,7 +91,7 @@
void DelayedCookieMonster::InvokeGetCookiesCallback(
const CookieMonster::GetCookieInfoCallback& callback) {
if (!callback.is_null())
- callback.Run(&cookie_line_, &cookie_info_);
+ callback.Run(cookie_line_, cookie_info_);
}
void DelayedCookieMonster::InvokeSetCookiesCallback(
« no previous file with comments | « net/base/cookie_store_test_helpers.h ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698