Issue 7833040: Fix possible crash in FixedDoubleArray::Initialize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7833040: Fix possible crash in FixedDoubleArray::Initialize() (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow

Modified:
9 years, 3 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix possible crash in FixedDoubleArray::Initialize() (this only affected ia32). BUG=95113 TEST=mjsunit/regress/regress-95113.js passes without crashing. Committed: http://code.google.com/p/v8/source/detail?r=9153

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Patch Set 3 : remove forgotten unused variable #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -3 lines)			Patch
	M	src/objects-inl.h	View	1 2	1 chunk	+9 lines, -3 lines	0 comments	Download
	A	test/mjsunit/regress/regress-95113.js	View		1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danno

http://codereview.chromium.org/7833040/diff/1/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7833040/diff/1/src/objects-inl.h#newcode1765 src/objects-inl.h:1765: WRITE_DOUBLE_FIELD(this, offset, hole_nan_as_double()); just do set(current, from->get(current)) and don't ...

9 years, 3 months ago (2011-09-06 13:22:13 UTC) #2

Jakob Kummerow

9 years, 3 months ago (2011-09-06 13:31:03 UTC) #3

LGTM

Expand Messages | Collapse Messages