Issue 7833031: Convert zoom and widget to IDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7833031: Convert zoom and widget to IDL (Closed)

Created:
9 years, 3 months ago by noelallen1

Modified:
9 years, 3 months ago

Reviewers:
dmichael (off chromium), noelallen_use_chromium

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Convert c/dev ppp_zoom_dev and ppp_widget_dev to IDL TEST= ./generator.py & try BUG= http://code.google.com/p/chromium/issues/detail?id=89968 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99823

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -13 lines)			Patch
A	ppapi/api/dev/ppp_widget_dev.idl	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	ppapi/api/dev/ppp_zoom_dev.idl	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	ppapi/c/dev/ppp_widget_dev.h	View	1 chunk	+30 lines, -5 lines	0 comments	Download
M	ppapi/c/dev/ppp_zoom_dev.h	View	1 chunk	+29 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

LGTM How does one generate these? Does it happen with the usual command-line?

9 years, 3 months ago (2011-09-06 17:19:11 UTC) #2

noelallen_use_chromium

9 years, 3 months ago (2011-09-06 20:18:53 UTC) #3

The command-line is simply:
   src/ppapi/generators$ ./generator.py

This will generate with the defaults of
    --range=M13,M14
    --wnone (no warnings)
    --cgen (use C header generator)
    --dstroot=../c
    --srcroot=../api

If no file names are specified on the command line, the parser will
use:  *.idl, dev/*.idl, and trusted/*.idl

-Noel


On Tue, Sep 6, 2011 at 10:19 AM,  <dmichael@chromium.org> wrote:
> LGTM
>
> How does one generate these? Does it happen with the usual command-line?
>
> http://codereview.chromium.org/7833031/
>

Expand Messages | Collapse Messages