Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 7833030: Revert 99666 (sync tests started failing on mac10.6: (Closed)

Created:
9 years, 3 months ago by Nico
Modified:
9 years, 3 months ago
Reviewers:
Craig
CC:
chromium-reviews, Alexander Potapenko, Timur Iskhodzhanov, cbentzel+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Revert 99666 (sync tests started failing on mac10.6: http://build.chromium.org/p/chromium/builders/Mac10.6%20Sync/builds/9198 - Linux: Monitor resolv.conf for changes and use that to reload resolver. BUG=67734 TEST=manual testing by poking at resolv.conf Review URL: http://codereview.chromium.org/6903061 TBR=craig.schlenter@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -330 lines) Patch
A + net/base/dns_reload_timer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/base/dns_reload_timer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D net/base/dns_reloader.h View 1 chunk +0 lines, -24 lines 0 comments Download
D net/base/dns_reloader.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M net/base/dnsrr_resolver.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M net/base/host_resolver_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/base/host_resolver_impl.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M net/base/host_resolver_proc.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M net/base/network_change_notifier.h View 4 chunks +0 lines, -21 lines 0 comments Download
M net/base/network_change_notifier.cc View 3 chunks +1 line, -25 lines 0 comments Download
M net/base/network_change_notifier_linux.cc View 4 chunks +1 line, -57 lines 0 comments Download
M net/net.gyp View 16 chunks +35 lines, -35 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
9 years, 3 months ago (2011-09-05 23:40:44 UTC) #1
Craig
This is wrong. My patch has nothing to do with sync integration tests on mac ...
9 years, 3 months ago (2011-09-06 03:38:29 UTC) #2
Nico
Yeah, didn't help. I'm reverting the revert. It's hard to tell in advance. On Mon, ...
9 years, 3 months ago (2011-09-06 03:41:10 UTC) #3
Craig
9 years, 3 months ago (2011-09-06 04:22:01 UTC) #4
On 2011/09/06 03:41:10, Nico wrote:
> Yeah, didn't help. I'm reverting the revert. It's hard to tell in advance.

Thanks for relanding!

The sync stuff was flaky when I did the initial try runs but r99654 was supposed
to fix that. I'll dig a bit to see if I spot anything else that might be
related.

Powered by Google App Engine
This is Rietveld 408576698