Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/resources/ntp4/tile_page.js

Issue 7833021: [ntp4] Add a 'Manage Bookmarks' link at the top of the Bookmarks page. Also right-align links. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.html ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/tile_page.js
===================================================================
--- chrome/browser/resources/ntp4/tile_page.js (revision 99697)
+++ chrome/browser/resources/ntp4/tile_page.js (working copy)
@@ -449,6 +449,15 @@
},
/**
+ * Returns any extra padding to insert to the bottom of a tile page. By
+ * default there is none, but subclasses can override.
+ * @type {number}
+ */
+ get extraBottomPadding() {
+ return 0;
+ },
+
+ /**
* Cleans up resources that are no longer needed after this TilePage
* instance is removed from the DOM.
*/
@@ -486,6 +495,7 @@
this.tileElements_[index]);
}
this.calculateLayoutValues_();
+ this.heightChanged_();
this.positionTile_(index);
},
@@ -755,7 +765,8 @@
// a flex box, and the tile grid could be box-flex: 1, but this exposes a
// bug where repositioning tiles will cause the scroll position to reset.
this.tileGrid_.style.minHeight = (this.clientHeight -
- this.tileGrid_.offsetTop) + 'px';
+ this.tileGrid_.offsetTop - this.content_.offsetTop -
+ this.extraBottomPadding) + 'px';
},
/**
« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.html ('k') | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698