[ntp4] Add a 'Manage Bookmarks' link at the top of the Bookmarks page. Also right-align links.

chrome/browser/resources/ntp4/tile_page.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp4', function() {
   'use strict';
 
   // We can't pass the currently dragging tile via dataTransfer because of
   // http://crbug.com/31037
   var currentlyDraggingTile = null;
@@ skipping 301 matching lines @@
 
   // The proportion of the tile width which will be used as spacing between
   // tiles.
   var TILE_SPACING_FRACTION = 1 / 8;
 
   // The smallest amount of horizontal blank space to display on the sides when
   // displaying a wide arrangement. There is an additional 26px of margin from
   // the tile page padding.
   var MIN_WIDE_MARGIN = 18;
 
+  // Extra space to allow at the bottom of a tilegrid when setting the
+  // min-height property.  This is a bit of a hack to allow pages to insert
+  // small content at the bottom.
+  // TODO(csilv): Remove the need for this.
+  var TILE_GRID_EXTRA_PADDING = 40;

[Evan Stade, 2011/09/05 01:59:20]

can you do this as a function on TilePage which children of TilePage can
override, like

ExtraBottomPadding: function() {
  return 40;
}

that way I think it's not such a hack.

[csilv, 2011/09/06 05:33:33]

Done.

+
   /**
    * Creates a new TilePage object. This object contains tiles and controls
    * their layout.
    * @param {Object} gridValues Pixel values that define the size and layout
    *     of the tile grid.
    * @constructor
    * @extends {HTMLDivElement}
    */
   function TilePage(gridValues) {
     var el = cr.doc.createElement('div');
@@ skipping 147 matching lines @@
       if (animate)
         tileElement.classList.add('new-tile-contents');
       var wrapperDiv = new Tile(tileElement);
       if (index == this.tileElements_.length) {
         this.tileGrid_.appendChild(wrapperDiv);
       } else {
         this.tileGrid_.insertBefore(wrapperDiv,
                                     this.tileElements_[index]);
       }
       this.calculateLayoutValues_();
+      this.heightChanged_();
 
       this.positionTile_(index);
     },
 
     /**
      * Removes the given tile and animates the respositioning of the other
      * tiles.
      * @param {HTMLElement} tile The tile to remove from |tileGrid_|.
      * @param {?boolean} animate If true, tiles will animate.
      */
@@ skipping 249 matching lines @@
      * Called when the height of |this| has changed: update the size of
      * tileGrid.
      * @private
      */
     heightChanged_: function() {
       // The tile grid will expand to the bottom footer, or enough to hold all
       // the tiles, whichever is greater. It would be nicer if tilePage were
       // a flex box, and the tile grid could be box-flex: 1, but this exposes a
       // bug where repositioning tiles will cause the scroll position to reset.
       this.tileGrid_.style.minHeight = (this.clientHeight -
-          this.tileGrid_.offsetTop) + 'px';
+          this.tileGrid_.offsetTop - this.content_.offsetTop -
+          TILE_GRID_EXTRA_PADDING) + 'px';
     },
 
     /**
      * Scrolls the page in response to a mousewheel event.
      * @param {Event} e The mousewheel event.
      */
     handleMouseWheel: function(e) {
       this.content_.scrollTop -= e.wheelDeltaY / 3;
     },
 
@@ skipping 272 matching lines @@
     setDropEffect: function(dataTransfer) {
       assert(false);
     },
   };
 
   return {
     getCurrentlyDraggingTile: getCurrentlyDraggingTile,
     TilePage: TilePage,
   };
 });