Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 7833017: Fix nacl_helper startup bug with command line construction. (Closed)

Created:
9 years, 3 months ago by Brad Chen
Modified:
9 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix nacl_helper startup bug with command line construction. Add proper chrome dependencies. Re-enable nacl_helper. BUG=92964, nativeclient:480, 95168 TEST=nacl_integration tests on bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99617

Patch Set 1 #

Patch Set 2 : Disable nacl_helper while we try to settle some build problems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/chrome_exe.gypi View 1 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/nacl/nacl_fork_delegate_linux.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Brad Chen
By the way Brad Nelson had already LGTMed the gyp changes.
9 years, 3 months ago (2011-09-03 09:26:11 UTC) #1
Brad Chen
adding evanm
9 years, 3 months ago (2011-09-04 00:59:28 UTC) #2
evanm
LGTM On Sat, Sep 3, 2011 at 5:59 PM, <bradchen@google.com> wrote: > adding evanm > ...
9 years, 3 months ago (2011-09-04 07:33:41 UTC) #3
evanm
LGTM On Sat, Sep 3, 2011 at 5:59 PM, <bradchen@google.com> wrote: > adding evanm > ...
9 years, 3 months ago (2011-09-04 07:33:44 UTC) #4
Brad Chen
Mark, Roland, let me know if you have any ideas about other things to try ...
9 years, 3 months ago (2011-09-04 15:50:56 UTC) #5
Brad Chen
Mark, Roland, let me know if you have any ideas about other things to try ...
9 years, 3 months ago (2011-09-04 15:51:00 UTC) #6
commit-bot: I haz the power
9 years, 3 months ago (2011-09-05 01:17:59 UTC) #7
Change committed as 99617

Powered by Google App Engine
This is Rietveld 408576698