Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 7832003: A temporary workaround for huge heap snapshots problem. (Closed)

Created:
9 years, 3 months ago by mnaganov (inactive)
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

A temporary workaround for huge heap snapshots problem. Do not try to serialize them into JSON to avoid crashing / hanging DevTools. R=sgjesse@chromium.org BUG=v8:1658, 89268 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=9123

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M src/profile-generator.h View 4 chunks +4 lines, -2 lines 0 comments Download
M src/profile-generator.cc View 3 chunks +30 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
9 years, 3 months ago (2011-09-02 15:11:42 UTC) #1
Søren Thygesen Gjesse
LGTM
9 years, 3 months ago (2011-09-05 06:54:23 UTC) #2
William Hesse
http://codereview.chromium.org/7832003/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/7832003/diff/1/src/profile-generator.cc#newcode2985 src/profile-generator.cc:2985: 384 * 1024; We have constants KB, MB, and ...
9 years, 3 months ago (2011-09-05 07:31:00 UTC) #3
mnaganov (inactive)
9 years, 3 months ago (2011-09-05 07:33:10 UTC) #4
http://codereview.chromium.org/7832003/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/7832003/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:2985: 384 * 1024;
On 2011/09/05 07:31:00, William Hesse wrote:
> We have constants KB, MB, and GB defined in globals.h for the binary orders of
> magnitude.  I would use KB instead of 1024.

Thanks! I forgot about that, will fix before landing.

Powered by Google App Engine
This is Rietveld 408576698