Issue 7831053: Move NaCl tests out of chrome/test

Issue 7831053: Move NaCl tests out of chrome/test (Closed)

Created:
9 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 3 months ago

Reviewers:
Mark Seaborn, bradnelson

CC:
chromium-reviews, native-client-reviews_googlegroups.com, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -971 lines)			Patch
M	build/all.gyp	View	1	5 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	2 chunks	+0 lines, -200 lines	0 comments	Download
D	chrome/test/nacl/nacl_sandbox_test.h	View		1 chunk	+0 lines, -28 lines	0 comments	Download
D	chrome/test/nacl/nacl_sandbox_test.cc	View		1 chunk	+0 lines, -46 lines	0 comments	Download
D	chrome/test/nacl/nacl_test.h	View		1 chunk	+0 lines, -63 lines	0 comments	Download
D	chrome/test/nacl/nacl_test.cc	View		1 chunk	+0 lines, -104 lines	0 comments	Download
D	chrome/test/nacl/nacl_ui_test.h	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	chrome/test/nacl/nacl_ui_test.cc	View		1 chunk	+0 lines, -88 lines	0 comments	Download
D	chrome/test/nacl_security_tests/commands_posix.h	View		1 chunk	+0 lines, -54 lines	0 comments	Download
D	chrome/test/nacl_security_tests/commands_posix.cc	View		1 chunk	+0 lines, -113 lines	0 comments	Download
D	chrome/test/nacl_security_tests/nacl_security_tests_linux.cc	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	chrome/test/nacl_security_tests/nacl_security_tests_mac.cc	View		1 chunk	+0 lines, -46 lines	0 comments	Download
D	chrome/test/nacl_security_tests/nacl_security_tests_posix.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
D	chrome/test/nacl_security_tests/nacl_security_tests_win.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
D	chrome/test/nacl_security_tests/nacl_security_tests_win.cc	View		1 chunk	+0 lines, -134 lines	0 comments	Download

Total messages: 4 (0 generated)

Mark Seaborn

Those tests are obsolete and really they should just be removed. See http://code.google.com/p/chromium/issues/detail?id=89352 I was ...

9 years, 3 months ago (2011-09-08 20:04:42 UTC) #2

Paweł Hajdan Jr.

Thank you, that's very helpful! PTAL, now just removing the files.

9 years, 3 months ago (2011-09-08 20:44:34 UTC) #3

LGTM, thanks!