Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 7831051: content: Move collected cookies constrained window to TabContentsWrapper. (Closed)

Created:
9 years, 3 months ago by Elliot Glaysher
Modified:
9 years, 3 months ago
CC:
chromium-reviews, jennb, kkania, dcheng, Dmitry Titov, jianli, Paweł Hajdan Jr.
Visibility:
Public.

Description

content: Move collected cookies constrained window to TabContentsWrapper. To split the ConstrainedWindow feature off of TabContents entirely (moving it to a helper object on TabContentsWrapper), I'll need to first make each constrained window TabContentsWrapper aware first. I started just hacking BUG=95257 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99872

Patch Set 1 #

Patch Set 2 : win/chromeos fixes #

Patch Set 3 : Collected Cookies Win? Moar like Collect Cookies FAIL. #

Patch Set 4 : Compile failures for everyone\! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -115 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 2 3 6 chunks +15 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.cc View 7 chunks +12 lines, -19 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/collected_cookies_win.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_win.cc View 1 2 3 8 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/dialog_stubs_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/collected_cookies_ui_delegate.h View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/collected_cookies_ui_delegate.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
So my current plan to move the constrained window stuff from TabContents to TabContentsWrapper is ...
9 years, 3 months ago (2011-09-06 18:17:33 UTC) #1
prasadt
lgtm for panel.*
9 years, 3 months ago (2011-09-06 20:13:23 UTC) #2
jam
lgtm
9 years, 3 months ago (2011-09-06 21:45:15 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-07 00:05:00 UTC) #4
Change committed as 99872

Powered by Google App Engine
This is Rietveld 408576698