Issue 7831050: Revert 99236 - Very short-term change: while working on proper long-term solution,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7831050: Revert 99236 - Very short-term change: while working on proper long-term solution, (Closed)

Created:
9 years, 3 months ago by Chris Rogers

Modified:
9 years, 3 months ago

Reviewers:
enal

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 99236 - Very short-term change: while working on proper long-term solution, workaround for race condition that causes clicks and bad audio stream. Yield if reader was called too quickly after previous call, as there are good chances renderer thread did not fill the buffer yet. This breaks the Web Audio API completely on Mac OS X, and hoses audio for ALL applications, requiring reboot. BUG=http://code.google.com/p/chromium/issues/detail?id=61022 Review URL: http://codereview.chromium.org/7755001 TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99446

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -46 lines)			Patch
M	content/browser/renderer_host/media/audio_sync_reader.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/media/audio_sync_reader.cc	View	3 chunks	+2 lines, -20 lines	0 comments	Download
M	media/audio/audio_util.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	media/audio/audio_util.cc	View	3 chunks	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages