chrome/renderer/mock_render_thread.cc - Issue 7831041: Fix print preview workflow to reflect settings of selected printer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/mock_render_thread.cc

Issue 7831041: Fix print preview workflow to reflect settings of selected printer. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Update per code review Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/printing_message_filter.cc ('K') | « chrome/renderer/mock_render_thread.h ('k') | chrome/renderer/print_web_view_helper.h » ('j') | chrome/renderer/print_web_view_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/mock_render_thread.cc

diff --git a/chrome/renderer/mock_render_thread.cc b/chrome/renderer/mock_render_thread.cc

index 0e074d6caba31d4245057a2bf6fb5351e57eaed5..54022829f7a56838a25f2b1e667517e3395aee72 100644

--- a/chrome/renderer/mock_render_thread.cc

+++ b/chrome/renderer/mock_render_thread.cc

@@ -233,7 +233,6 @@ void MockRenderThread::OnCheckForCancel(const std::string& preview_ui_addr,

}

void MockRenderThread::OnUpdatePrintSettings(

- int document_cookie,

const DictionaryValue& job_settings,

PrintMsg_PrintPages_Params* params) {

// Check and make sure the required settings are all there.

@@ -274,7 +273,7 @@ void MockRenderThread::OnUpdatePrintSettings(

}

std::vector<int> pages(printing::PageRange::GetPages(new_ranges));

- printer_->UpdateSettings(document_cookie, params, pages);

+ printer_->UpdateSettings(params, pages);

}