chrome/browser/resources/print_preview/print_preview.js - Issue 7831041: Fix print preview workflow to reflect settings of selected printer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 7831041: Fix print preview workflow to reflect settings of selected printer. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Update per code review Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/printing_message_filter.cc ('K') | « chrome/browser/printing/printing_message_filter.cc ('k') | chrome/renderer/print_web_view_helper.h » ('j') | chrome/renderer/print_web_view_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_preview.js

diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js

index b085402df58fcc46bdd22ba82af4a6d2652a88cb..79f5f6003ce3bda6fbadb9eb973ba7456bf80a63 100644

--- a/chrome/browser/resources/print_preview/print_preview.js

+++ b/chrome/browser/resources/print_preview/print_preview.js

@@ -881,7 +881,7 @@ function printPreviewFailed() {

/**

* Display an error message when encountered invalid printer settings.

- * Called from PrintPreviewMessageHandler::OnInvalidDefaultPrinter().

+ * Called from PrintPreviewMessageHandler::OnInvalidPrinterSettings().

function invalidPrinterSettings() {

displayErrorMessage(localStrings.getString('invalidPrinterSettings'));