Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4291)

Unified Diff: chrome/browser/content_settings/content_settings_provider.h

Issue 7831004: Add a method to the content_settings::ProviderInterface to return the content settings Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove orphan code in content_settings_policy_provider_unittest.cc. sry Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_provider.h
diff --git a/chrome/browser/content_settings/content_settings_provider.h b/chrome/browser/content_settings/content_settings_provider.h
index 8065dbefb96c3f948615ceed047a35fb40cda34a..d4726cb9bb7e3393c58431af8753dcb1b3e83aa2 100644
--- a/chrome/browser/content_settings/content_settings_provider.h
+++ b/chrome/browser/content_settings/content_settings_provider.h
@@ -13,6 +13,7 @@
#include <string>
#include <vector>
+#include "base/values.h"
#include "chrome/browser/content_settings/content_settings_pattern.h"
#include "chrome/common/content_settings.h"
@@ -75,6 +76,21 @@ class ProviderInterface {
ContentSettingsType content_type,
const ResourceIdentifier& resource_identifier) const = 0;
+ // Returns the content setting |Value| for the given |content_type| which
+ // applies to the given |primary_url|, |secondary_url| pair. The ownership of
+ // the returned |Value| pointer is transfered to the caller. If no content
+ // settings value is available for the given parameter then NULL is returned.
wtc 2011/09/01 18:21:09 Nit: perhaps "parameter" should be "parameters" (p
markusheintz_ 2011/09/02 15:22:21 Done.
+ // For ContentSettingsTypes that require a resource identifier to be
+ // specified, the |resource_identifier| must be non-empty.
+ //
+ // This may be called on any thread.
+ virtual Value* GetContentSettingValue(
+ const GURL& primary_url,
+ const GURL& secondary_url,
+ ContentSettingsType content_type,
+ const ResourceIdentifier& resource_identifier) const = 0;
+
+
// Sets the content setting for a particular |primary_pattern|,
// |secondary_pattern|, |content_type| tuple. For ContentSettingsTypes that
// require a resource identifier to be specified, the |resource_identifier|

Powered by Google App Engine
This is Rietveld 408576698