Issue 7831003: Add Profile data to the Task Manager on OS Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7831003: Add Profile data to the Task Manager on OS Mac.

Created:
9 years, 3 months ago by mirandac

Modified:
9 years, 3 months ago

Reviewers:
Nico, Miranda Callahan

CC:
chromium-reviews, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add Profile data to the Task Manager on OS Mac. BUG=94936 TEST=existing tests modified. "profile" column added to task manager, default hidden.

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -3 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_notification_resource_provider.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.h	View	6 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View	6 chunks	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/task_manager_mac.mm	View	4 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

The way one has to go through the ProfileInfoCache to get a profile name is ...

9 years, 3 months ago (2011-09-01 13:04:50 UTC) #1

Miranda Callahan

9 years, 3 months ago (2011-09-01 13:37:42 UTC) #3

On 2011/09/01 13:26:14, Nico wrote:
> lgtm

(unit tests fixed and added and changed to mirandac@chromium (stupid computer)
at http://codereview.chromium.org/7828007/ .)

Expand Messages | Collapse Messages