Allow window.close() in background pages.

Allow window.close() in background pages.

BUG=81759
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99910

[Tessa MacDuff, 2011-09-03 00:17:45]

I'm writing a test now.  I'm still hoping to get this in before the m15 cutoff
if that's possible...

[Tessa MacDuff, 2011-09-03 06:18:27]

I wrote a test!

The test/demo extension closes the background page when you click the browser
action so I decided to put it browser_action_apitest.cc was even though the
background page can be closed in other contexts.  (I initially wrote a simpler
test extension that didn't use a browser action but the only place that seemed
to belong was extension_browsertests_misc.cc which begs not to be added to.)

Let me know if there is a better place or a simpler test.

[Tessa MacDuff, 2011-09-03 19:02:42]

Mihai, I was hoping to get this small change into m15 so if you happen to want
to do a little code review this weekend I'd be very appreciative.  The try jobs
before my new test all pass, and they only fail on my test because the trybot
can't load the new png.

Obviously the change isn't super critical, it's just the second half of my first
change (r98981) and I set it as a goal to get them both into m15.  This half is
NOT behind the switch so it could affect existing extensions.  I did a quick
ExtPlorer search and found 41 extensions have a background page with the string
'window.close()' (I didn't look into any external scripts so there will be more
than that).  I wonder if they ever noticed that it doesn't work...

[Aaron Boodman, 2011-09-06 19:47:04]

lgtm, sorry for lagging

http://codereview.chromium.org/7830046/diff/3004/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/7830046/diff/3004/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_process_manager.cc:346:
DCHECK(background_hosts_.find(host) == background_hosts_.end());
Don't be a wuss! CHECK

[Tessa MacDuff, 2011-09-07 00:59:21]

http://codereview.chromium.org/7830046/diff/3004/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_process_manager.cc (right):

http://codereview.chromium.org/7830046/diff/3004/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_process_manager.cc:346:
DCHECK(background_hosts_.find(host) == background_hosts_.end());
On 2011/09/06 19:47:04, Aaron Boodman wrote:
> Don't be a wuss! CHECK

I'm no wuss! Done!

[commit-bot: I haz the power, 2011-09-07 03:51:08]

Change committed as 99910