Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: test/mjsunit/builtins.js

Issue 7830036: Optimize isFinite and isNaN. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Made the change general by moving putting it in the NUMBER_IS_FINITE macro. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-regexp.cc ('k') | test/mjsunit/harmony/debug-blockscopes.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // Flags: --expose-natives-as=builtins
29
30 // Checks that all function properties of the builtin object are neither
31 // writable nor configurable. Also, theose functions that are actually
32 // constructors (recognized by having properties on their .prototype object),
33 // have only unconfigurable properties on the prototype, and the methods
34 // are also non-writable.
35
36 var names = Object.getOwnPropertyNames(builtins);
37
38 function isFunction(obj) {
39 return typeof obj == "function";
40 }
41
42 function checkConstructor(func, name) {
43 // A constructor is a function with a prototype and properties on the
44 // prototype object besides "constructor";
45 if (name.charAt(0) == "$") return;
46 if (typeof func.prototype != "object") return;
47 var propNames = Object.getOwnPropertyNames(func.prototype);
48 if (propNames.length == 0 ||
49 (propNames.length == 1 && propNames[0] == "constructor")) {
50 // Not a constructor.
51 return;
52 }
53 var proto_desc = Object.getOwnPropertyDescriptor(func, "prototype");
54 assertTrue(proto_desc.hasOwnProperty("value"), name);
55 assertFalse(proto_desc.writable, name);
56 assertFalse(proto_desc.configurable, name);
57 var prototype = proto_desc.value;
58 assertEquals(null, prototype.__proto__, name);
59 assertFalse(Object.isExtensible(prototype), name);
60 for (var i = 0; i < propNames.length; i++) {
61 var propName = propNames[i];
62 if (propName == "constructor") continue;
63 var testName = name + "-" + propName;
64 var propDesc = Object.getOwnPropertyDescriptor(prototype, propName);
65 assertTrue(propDesc.hasOwnProperty("value"), testName);
66 assertFalse(propDesc.configurable, testName);
67 if (isFunction(propDesc.value)) {
68 assertFalse(propDesc.writable, testName);
69 }
70 }
71 }
72
73 for (var i = 0; i < names.length; i++) {
74 var name = names[i];
75 var desc = Object.getOwnPropertyDescriptor(builtins, name);
76 assertTrue(desc.hasOwnProperty("value"));
77 var value = desc.value;
78 if (isFunction(value)) {
79 assertFalse(desc.writable, name);
80 assertFalse(desc.configurable, name);
81 checkConstructor(value, name);
82 }
83 }
OLDNEW
« no previous file with comments | « test/cctest/test-regexp.cc ('k') | test/mjsunit/harmony/debug-blockscopes.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698