CrOS - Fix file picker to route callbacks using TabContents

CrOS - Fix file picker to route callbacks using TabContents

Previously, when the user clicked open/save/cancel in the CrOS file picker, it would route that callback data to the frontmost tab.  Sometimes other tabs can switch to frontmost, however.  Use set_associated_tab_contents() to inform the extension function implementions of the tab to which to route the callbacks.  This also adds a test from tbarzic for the referenced bug.

BUG=chromium-os:18956
TEST=browser_tests FileManagerDialogTest.*, also verify you can open the file picker and open/save/cancel under normal conditions


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99327

[James Cook, 2011-09-01 21:23:47]

Robert, Toni, please take a look.  This is a better fix than hacking the URL -
it reuses some scaffolding in place for infobars (AssociatedTabContents for an
extension).

[tbarzic, 2011-09-01 21:33:25]

On 2011/09/01 21:23:47, James Cook (Chromium) wrote:
> Robert, Toni, please take a look.  This is a better fix than hacking the URL -
> it reuses some scaffolding in place for infobars (AssociatedTabContents for an
> extension).
LGTM
LGTM

[rginda, 2011-09-01 22:18:19]

On 2011/09/01 21:33:25, tbarzic wrote:
> On 2011/09/01 21:23:47, James Cook (Chromium) wrote:
> > Robert, Toni, please take a look.  This is a better fix than hacking the URL
-
> > it reuses some scaffolding in place for infobars (AssociatedTabContents for
an
> > extension).
> LGTM
> LGTM

LGTM, too

[commit-bot: I haz the power, 2011-09-02 05:52:47]

Change committed as 99327