Add Bus::ShutdownOnDBusThreadAndBlock() and remove bus::Shutdown()

Add Bus::ShutdownOnDBusThreadAndBlock() and remove bus::Shutdown()
    
This function is intended to use at the the very end of the browser shutdown,
where it it makes more sense to shut down the bus synchronously, than trying
to make it asynchronous.

Remove Bus::Shutdown() as we are unlikely to need it for the production code.

BUG=chromium:90036
TEST=dbus_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99331

[stevenjb, 2011-09-01 17:53:44]

http://codereview.chromium.org/7830009/diff/1/dbus/bus.h
File dbus/bus.h (right):

http://codereview.chromium.org/7830009/diff/1/dbus/bus.h#newcode236
dbus/bus.h:236: virtual void ShutdownAndBlockWithDBusThread();
Do we need to expose both ShutdownAndBlock and ShutdownAndBlockWithDBusThread in
the public API, or could we make this ShutdownAndBlock, and the make the
existing function private, e.g. ShutdownAndBlockInternal? It seems a bit
excessive to have three public Shutdown methods.

[satorux1, 2011-09-01 17:57:29]

http://codereview.chromium.org/7830009/diff/1/dbus/bus.h
File dbus/bus.h (right):

http://codereview.chromium.org/7830009/diff/1/dbus/bus.h#newcode236
dbus/bus.h:236: virtual void ShutdownAndBlockWithDBusThread();
On 2011/09/01 17:53:44, Steven Bennetts wrote:
> Do we need to expose both ShutdownAndBlock and ShutdownAndBlockWithDBusThread
in
> the public API, or could we make this ShutdownAndBlock, and the make the
> existing function private, e.g. ShutdownAndBlockInternal? It seems a bit
> excessive to have three public Shutdown methods.

ShutdownAndBlock() is already used in wifi_data_provider_linux.cc, that runs on
its own thread.

ShutdownAndBlockWithDBusThread() will be used.

Shutdown() is currently only used in tests. This can be removed, as we probably
don't use it in the production code.

[stevenjb, 2011-09-01 18:19:33]

http://codereview.chromium.org/7830009/diff/1/dbus/bus.h
File dbus/bus.h (right):

http://codereview.chromium.org/7830009/diff/1/dbus/bus.h#newcode236
dbus/bus.h:236: virtual void ShutdownAndBlockWithDBusThread();
On 2011/09/01 17:57:30, satorux1 wrote:
> On 2011/09/01 17:53:44, Steven Bennetts wrote:
> > Do we need to expose both ShutdownAndBlock and
ShutdownAndBlockWithDBusThread
> in
> > the public API, or could we make this ShutdownAndBlock, and the make the
> > existing function private, e.g. ShutdownAndBlockInternal? It seems a bit
> > excessive to have three public Shutdown methods.
> 
> ShutdownAndBlock() is already used in wifi_data_provider_linux.cc, that runs
on
> its own thread.
> 
> ShutdownAndBlockWithDBusThread() will be used.
> 
> Shutdown() is currently only used in tests. This can be removed, as we
probably
> don't use it in the production code.

OK. In that case I suggest we name this ShutdownOnDBusThreadAndBlock(), and make
Shutdown() private (with tests as friends) or remove it.

[satorux1, 2011-09-01 18:37:00]

On 2011/09/01 18:19:33, Steven Bennetts wrote:
> http://codereview.chromium.org/7830009/diff/1/dbus/bus.h
> File dbus/bus.h (right):
> 
> http://codereview.chromium.org/7830009/diff/1/dbus/bus.h#newcode236
> dbus/bus.h:236: virtual void ShutdownAndBlockWithDBusThread();
> On 2011/09/01 17:57:30, satorux1 wrote:
> > On 2011/09/01 17:53:44, Steven Bennetts wrote:
> > > Do we need to expose both ShutdownAndBlock and
> ShutdownAndBlockWithDBusThread
> > in
> > > the public API, or could we make this ShutdownAndBlock, and the make the
> > > existing function private, e.g. ShutdownAndBlockInternal? It seems a bit
> > > excessive to have three public Shutdown methods.
> > 
> > ShutdownAndBlock() is already used in wifi_data_provider_linux.cc, that runs
> on
> > its own thread.
> > 
> > ShutdownAndBlockWithDBusThread() will be used.
> > 
> > Shutdown() is currently only used in tests. This can be removed, as we
> probably
> > don't use it in the production code.
> 
> OK. In that case I suggest we name this ShutdownOnDBusThreadAndBlock(), and
make
> Shutdown() private (with tests as friends) or remove it.

Agreed. I like the new function name. Renamed the function, and removed
Shutdown().

[stevenjb, 2011-09-01 19:58:14]

LGTM

[commit-bot: I haz the power, 2011-09-02 06:56:31]

Change committed as 99331