Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 7830004: move -m32 flag for ia32 targets from standalone.gypi to common.gypi (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow
Modified:
9 years, 3 months ago
Reviewers:
Peter Kasting, Yang
CC:
v8-dev
Visibility:
Public.

Description

move -m32 flag for ia32 targets from standalone.gypi to common.gypi so that we no longer depend on Chromium setting this flag. BUG=v8:1648 Committed: http://code.google.com/p/v8/source/detail?r=9095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Yang: PTAL. Peter: FYI.
9 years, 3 months ago (2011-09-01 09:50:27 UTC) #1
Yang
LGTM.
9 years, 3 months ago (2011-09-01 11:47:09 UTC) #2
Peter Kasting
9 years, 3 months ago (2011-09-01 19:43:17 UTC) #3
Thanks!

Powered by Google App Engine
This is Rietveld 408576698