Fix NaCl build error with ninja.

Fix NaCl build error with ninja.

Fix source-tree paths passed to compiler and linker flags of nacl_helper_bootstrap so that they are correct when building with ninja.

BUG=None
TEST=Manual: nacl_helper_bootstrap target should build both with make and ninja.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99796

[Ivan Korotkov, 2011-09-06 08:48:29]

Hi Evan,

this CL makes it possible to build NaCl with ninja. I'm not sure if there's no
better way to pass such paths as flag values. What about ninja generator
checking if flag value is a source-tree path and adding something like '../..'
to it automatically?

[Evan Martin, 2011-09-06 17:43:25]

On 2011/09/06 08:48:29, Ivan Korotkov wrote:
> this CL makes it possible to build NaCl with ninja.

Your approach is clever!  I suggest sending this to bradnelson instead.  It LGTM
but it is not code I'm familiar with.

> I'm not sure if there's no
> better way to pass such paths as flag values. What about ninja generator
> checking if flag value is a source-tree path and adding something like '../..'
> to it automatically?

That idea has a long history.  There are two flaws in it:
- it turns out to be difficult to determine whether a flag contains a path or
something that just looks like a path (which can introduce subtle problems)
- relative paths only work if you know what directory the cwd is.  I started
this thread about it:
https://groups.google.com/group/gyp-developer/browse_thread/thread/fc4dbd1dcd...

[Evan Martin, 2011-09-06 17:43:49]

Brad, what do you think about this change?  It's gross but at least slighly
better than before.

[bradn, 2011-09-06 18:06:41]

LGTM, but maybe lets wait for bradchen's sign off too?

It might be nice to sort out the broader issue, but it comes up rarely enough
that this seems like an ok workaround.

[Brad Chen, 2011-09-06 18:20:29]

LGTM

[commit-bot: I haz the power, 2011-09-06 20:05:09]

Change committed as 99796