Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 7828088: Change pnacl llvm triple to use nacl instead of linux inside plugin. (Closed)

Created:
9 years, 3 months ago by jvoung - send to chromium...
Modified:
9 years, 3 months ago
CC:
chromium-reviews, pnacl-team_google.com, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Change pnacl llvm triple to use nacl instead of linux (inside plugin). Inside driver change: http://codereview.chromium.org/7737032/ BUG= http://code.google.com/p/nativeclient/issues/detail?id=1554 TEST= build chrome, host files for "run_pnacl_example_browser_test" and "run_pnacl_bad_browser_test" from a nacl repo (since there is no pnacl toolchain downloaded in chrome repo) and load the test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99820

Patch Set 1 #

Patch Set 2 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung - send to chromium...
9 years, 3 months ago (2011-09-06 16:53:43 UTC) #1
robertm
LGTM
9 years, 3 months ago (2011-09-06 17:08:05 UTC) #2
sehr (please use chromium)
On 2011/09/06 17:08:05, robertm wrote: > LGTM LGTM.
9 years, 3 months ago (2011-09-06 17:25:31 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-06 21:08:16 UTC) #4
Presubmit check for 7828088-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

Powered by Google App Engine
This is Rietveld 408576698